removes invalid openssl check and bumps deps #217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@provegard mentioned on gitter that we are getting an openssl error. I think the check is no longer valid after we switched to latest JRE + spring boot 3, as when I remove the check, the docker image (alpine JRE 21) works fine. So, I'm removing the check and in worst case, if someone has a misconfiguration, they get a late error in /health, but we don't get a false report for everybody else.
Traces created with https://github.com/openzipkin/brave-example/tree/master/armeria and self-tracing too.
I ran the locally build docker image like so, configured with
Trace Agent
role$ docker run --rm -p 9411:9411 --name zipkin-gcp -e SELF_TRACING_ENABLED=true -e STORAGE_TYPE=stackdriver -e GOOGLE_APPLICATION_CREDENTIALS=/zipkin/.gcp/credentials.json -e STACKDRIVER_PROJECT_ID=adrian-test-414623 -v $HOME/.gcp:/zipkin/.gcp:ro openzipkin/zipkin-gcp:test