Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes invalid openssl check and bumps deps #217

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Conversation

codefromthecrypt
Copy link
Member

@provegard mentioned on gitter that we are getting an openssl error. I think the check is no longer valid after we switched to latest JRE + spring boot 3, as when I remove the check, the docker image (alpine JRE 21) works fine. So, I'm removing the check and in worst case, if someone has a misconfiguration, they get a late error in /health, but we don't get a false report for everybody else.

Traces created with https://github.com/openzipkin/brave-example/tree/master/armeria and self-tracing too.
I ran the locally build docker image like so, configured with Trace Agent role

$ docker run --rm -p 9411:9411 --name zipkin-gcp -e SELF_TRACING_ENABLED=true  -e STORAGE_TYPE=stackdriver   -e GOOGLE_APPLICATION_CREDENTIALS=/zipkin/.gcp/credentials.json   -e STACKDRIVER_PROJECT_ID=adrian-test-414623    -v $HOME/.gcp:/zipkin/.gcp:ro   openzipkin/zipkin-gcp:test

Screenshot 2024-02-18 at 08 15 24

@codefromthecrypt
Copy link
Member Author

ps we once had a test account and maybe I accidentally stopped it from running when updating CI config and/or removing travis.. I opened #218 to get automated integration test with a real account working again, which would have prevented not noticing this. I ad-hoc tested the server once in the last couple months, but broke it after!

@codefromthecrypt
Copy link
Member Author

I found when the docker CI workflow was accidentally deleted.. several years ago. running the tests again in case the credentials still work.

@codefromthecrypt
Copy link
Member Author

ok rolling back CI as the google-cloud account was revoked, which is not terribly surprising the years

{
  "status" : "DOWN",
  "zipkin" : {
    "status" : "DOWN",
    "details" : {
      "StackdriverStorage{zipkin-gcp-ci}" : {
        "status" : "DOWN",
        "details" : {
          "error" : "com.google.auth.oauth2.GoogleAuthException: Error getting access token for service account: 400 Bad Request\nPOST [https://oauth2.googleapis.com/token\n{\](https://oauth2.googleapis.com/token/n%7B/)"error\":\"invalid_grant\",\"error_description\":\"Invalid grant: account not found\"}, iss: zipkin-gcp-ci-github@zipkin-gcp-ci.iam.gserviceaccount.com"
        }
      }
    }
  }
}

we'll just do ad-hoc integration tests until someone at google gives us an account again.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt codefromthecrypt merged commit 40a6209 into master Feb 18, 2024
2 checks passed
@codefromthecrypt codefromthecrypt deleted the bumps-n-fix branch February 18, 2024 04:02
@codefromthecrypt
Copy link
Member Author

thanks for the look @reta!

@codefromthecrypt
Copy link
Member Author

@provegard
Copy link

I just tested the 2.2.2 tag, and it works like a charm. Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants